Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove system card mocks #320

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Remove system card mocks #320

merged 1 commit into from
Oct 31, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Oct 28, 2024 •
edited
Loading

Description

Removes usage of the (hardcoded) example/system_card and instead uses the system_card stored per project in the database.

Resolves #298

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert linked an issue Oct 28, 2024 that may be closed by this pull request
Remove (system card) mocks #298
Closed
9 tasks
@uittenbroekrobbert uittenbroekrobbert force-pushed the 298-remove-system-card-mocks branch 2 times, most recently from e4a8e51 to 6d5b042 Compare October 30, 2024 13:10
@uittenbroekrobbert uittenbroekrobbert marked this pull request as ready for review October 30, 2024 13:14
@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner October 30, 2024 13:14
@uittenbroekrobbert uittenbroekrobbert force-pushed the 298-remove-system-card-mocks branch 4 times, most recently from 8971e0c to 69def87 Compare October 30, 2024 14:28
laurensWe
laurensWe reviewed Oct 30, 2024
View reviewed changes
amt/api/routes/project.py Show resolved Hide resolved
amt/locale/nl_NL/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
amt/locale/nl_NL/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
amt/site/templates/projects/new.html.j2 Show resolved Hide resolved
amt/services/task_registry.py Show resolved Hide resolved
amt/schema/shared.py Show resolved Hide resolved
@uittenbroekrobbert uittenbroekrobbert force-pushed the 298-remove-system-card-mocks branch 3 times, most recently from de71380 to fa3d92a Compare October 31, 2024 06:30
laurensWe
laurensWe previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChristopherSpelt
ChristopherSpelt previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
90.5% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

@uittenbroekrobbert uittenbroekrobbert merged commit 7d8edf4 into main Oct 31, 2024
12 of 13 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 298-remove-system-card-mocks branch October 31, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

@laurensWe laurensWe laurensWe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove (system card) mocks
3 participants
@uittenbroekrobbert @laurensWe @ChristopherSpelt